[XS] Change in flashrom[main]: dummyflasher: assign address of function for LLVM - flashrom-gerrit

2 Jul 2024


      Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email )
Change subject: dummyflasher: assign address of function for LLVM
......................................................................
Patch Set 1:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/83262/comment/fdca1c36_2fa2d9a5?usp... :
PS1, Line 972: &
...
I agree this is odd; I'm not able to reproduce using Clang 16 in what looks like it should be a mini […]
I'm a tool.  The problem is the const.  Not sure what I've been testing.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/83262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952
Gerrit-Change-Number: 83262
Gerrit-PatchSet: 1
Gerrit-Owner: Fabian Groffen grobian@gentoo.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 02 Jul 2024 12:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org