[M] Change in flashrom[master]: dmi.c: Pass is_laptop by ref into dmi - flashrom-gerrit

9 Mar 2023


      Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71622 )
Change subject: dmi.c: Pass is_laptop by ref into dmi
......................................................................
Patch Set 4:
(1 comment)
File internal.c:
https://review.coreboot.org/c/flashrom/+/71622/comment/4bdbd3cf_f4eb66f8 
PS4, Line 31: laptop_ok
...
I am not sure I follow, this commit was to make dmi functional and rename the residual remaining, ha […]
Sorry when my intent was not clear.
I was thinking creating a patch before this, which moves `laptop_ok` to `g_laptop_ok`. And this patch here moves `is_laptop` to `g_is_laptop`, so we keep the naming scheme of those variables together. This would then also fixes the FIXME of `report_nonwl_laptop_detected()` with having an `_` to one of the variables.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d5ad6c0623269492d775a99a947fd6fe26c5f91
Gerrit-Change-Number: 71622
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 09 Mar 2023 11:15:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment