Attention is currently required from: Martin L Roth, Thomas Heijligen, Anastasia Klimchuk.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 )
Change subject: flashrom: rename sb600spi.c to amd_spi.c
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I actually like the name amd_something.c because it tells straight away that it's amd. Previously I had to map in my mind all the time sb600 -> oh that's amd. Now no need to do this "mapping" anymore!
I also opened the patch you linked: it actually uses amd_spi100 so the same naming scheme as Martin introduces in this patch.
What do you think?
Fair enough but then call it amd_sb600_spi.c ?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a
Gerrit-Change-Number: 74952
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 04 May 2023 13:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment