Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value - flashrom-gerrit

13 Sep 2021


      Attention is currently required from: Nico Huber, David Hendricks, Angel Pons, Arthur Heymans.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57580 )
Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57580/comment/f921ac86_e0ef3909 
PS1, Line 936: == 16
Maybe I am recognising a false pattern here but are the cases of [11, 15] also IBEX_PEAK? ifdtool.c considers the strap length with the case `<= 16` which seems actually what we want here?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/57580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8a880251a393666757f3879629a165b7fe3533ef
Gerrit-Change-Number: 57580
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: David Hendricks
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 13 Sep 2021 04:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment