Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57326 )
Change subject: tests: Add tests to read from chip
......................................................................
Patch Set 1:
(2 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/4ea53ca2_af3bc197
PS1, Line 232: 16
I was really wondering what this is about... I guess you mean the
check for `16 * 1024`? i.e. >16MiB chips
https://review.coreboot.org/c/flashrom/+/57326/comment/a958f11a_cb73fd82
PS1, Line 246: };
Should these be static/global so they can be shared among test functions?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia57781ebc670c7bd6197e56fe8a20651a425c756
Gerrit-Change-Number: 57326
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 18:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment