Nico Huber has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/25683/2/Makefile File Makefile:
https://review.coreboot.org/#/c/25683/2/Makefile@948 PS2, Line 948: LIBS += -lni845x
I have not find an explicit license for the NI 845x, but a txt file in the installation folder links […]
I didn't mean to warn anybody of NI's wrath but ours. flashrom authors have rights too.
If somebody sells a binary of flashrom along with or as his product, they have to adhere to the GPL. In this case this would mean to provide access to NI's source code under a GPL compatible license, which could cause them some trouble ;)
However, building such binary for yourself and using it is absolutely fine. So it's not a big deal, I guess, as long as NI845X_SPI is disabled by default and nobody links to it by accident.
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c File ni845x_spi.c:
PS2:
Camel cases removed, do you have an example of what parameters should I use with indent?
Hmmm, looks like this was never formalized for flashrom. `indent -linux -l112` might do, not sure. Though, looking closer at the code, the indentation itself seems to be the only (obvious) problem, it should just be a tab.
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c@47 PS2, Line 47: uInt32
The NI USB-854x API brings these types and I thought that using them for the library calls only woul […]
Hard to argue about that. But uInt32 seems to translate rather safely to uint32_t. Your call.
-
Nico Huber (Code Review)