Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/41775 )
Change subject: libflashrom.c: Use casts on enum conversions ......................................................................
libflashrom.c: Use casts on enum conversions
This allows flashrom to build with GCC 10.
Change-Id: I2166cdf3681452631ef8e980face2924e9a6c81a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M libflashrom.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/41775/1
diff --git a/libflashrom.c b/libflashrom.c index ab7e364..c20d9c7 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -188,7 +188,8 @@ for (; i < boards_known_size; ++i) { supported_boards[i].vendor = binfo[i].vendor; supported_boards[i].name = binfo[i].name; - supported_boards[i].working = binfo[i].working; + supported_boards[i].working = + (enum flashrom_test_state) binfo[i].working; } } else { msg_gerr("Memory allocation error!\n"); @@ -226,7 +227,8 @@ supported_chipsets[i].chipset = chipset[i].device_name; supported_chipsets[i].vendor_id = chipset[i].vendor_id; supported_chipsets[i].chipset_id = chipset[i].device_id; - supported_chipsets[i].status = chipset[i].status; + supported_chipsets[i].status = + (enum flashrom_test_state) chipset[i].status; } } else { msg_gerr("Memory allocation error!\n");
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41775 )
Change subject: libflashrom.c: Use casts on enum conversions ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/41775 )
Change subject: libflashrom.c: Use casts on enum conversions ......................................................................
libflashrom.c: Use casts on enum conversions
This allows flashrom to build with GCC 10.
Change-Id: I2166cdf3681452631ef8e980face2924e9a6c81a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/41775 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M libflashrom.c 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/libflashrom.c b/libflashrom.c index ab7e364..c20d9c7 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -188,7 +188,8 @@ for (; i < boards_known_size; ++i) { supported_boards[i].vendor = binfo[i].vendor; supported_boards[i].name = binfo[i].name; - supported_boards[i].working = binfo[i].working; + supported_boards[i].working = + (enum flashrom_test_state) binfo[i].working; } } else { msg_gerr("Memory allocation error!\n"); @@ -226,7 +227,8 @@ supported_chipsets[i].chipset = chipset[i].device_name; supported_chipsets[i].vendor_id = chipset[i].vendor_id; supported_chipsets[i].chipset_id = chipset[i].device_id; - supported_chipsets[i].status = chipset[i].status; + supported_chipsets[i].status = + (enum flashrom_test_state) chipset[i].status; } } else { msg_gerr("Memory allocation error!\n");