Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74631 )
Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions
......................................................................
Patch Set 3: Verified+1
(1 comment)
Patchset:
PS3:
I don't fully understand why jenkins gave -1 https://qa.coreboot. […]
Formally this meta data lands in the flashrom git repository. I think we do a catch-all to build flashrom for all changes to that repository. That's great to get branches build tested automatically but in this case there is no flashrom source code checked out and things fail. I will manually override Verified.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: refs/meta/config
Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da
Gerrit-Change-Number: 74631
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 21 Apr 2023 14:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment