Attention is currently required from: Thomas Heijligen, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74065 )
Change subject: util/flashchips_db_jsoniser: Initial version ......................................................................
Patch Set 1:
(1 comment)
File util/flashchips_db_jsoniser/main.c:
https://review.coreboot.org/c/flashrom/+/74065/comment/3c0ac95b_e9b52fc6 PS1, Line 69: static char *decode_test_state(enum test_state ts) : { : switch (ts) { : case OK: return "OK"; : case NT: return "NT"; : case BAD: return "BAD"; : case DEP: return "DEP"; : case NA: return "NA"; : } : return NULL; : }; : : static char *decode_cmdset(int cmdset) : { : switch (cmdset) { : case SPI25: return "SPI25"; : case SPI_EDI: return "SPI_EDI"; : } : return NULL; : }
Indentation: please use tabs instead of spaces
That doesn't matter. We are going to put this in the bin after we got the output.