Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Aarya.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c: Add functions for new erase selction algorithm ......................................................................
Patch Set 85:
(2 comments)
File erasure_layout.h:
https://review.coreboot.org/c/flashrom/+/65844/comment/3c16c64f_50d3493e PS83, Line 37: int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff_t region_end, uint8_t* curcontents, uint8_t* newcontents, struct erase_layout *erase_layout, bool *all_skipped);
Done
But it still looks the same in the latest patchset? :)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/8be44934_8a9d96ae PS84, Line 15: */
Done
I see you added file to build system, because now jenkins builds it, good!
Also jenkins build has an error, you can see it by: clicking the link which jenkins gives you with -1 clicking Console Output on the left menu scroll to the end of console output, it tells ``` erasure_layout.c: In function 'erase_write': erasure_layout.c:399:9: error: 'old_end_buf' may be used uninitialized [-Werror=maybe-uninitialized] 399 | memcpy(newcontents + old_end, old_end_buf, region_end - old_end); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ erasure_layout.c:264:18: note: 'old_end_buf' was declared here 264 | uint8_t *old_end_buf = (uint8_t *)malloc(region_end - old_end); | ^~~~~~~~~~~ cc1: all warnings being treated as errors ```