Attention is currently required from: Hsuan-ting Chen, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/82908?usp=email )
Change subject: how_to_add_new_chip: Add a section for feature bits and WRSR handling ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: I downloaded the patch to try generate locally and see how it looks. It looks good :) I only have one comment.
File doc/contrib_howtos/how_to_add_new_chip.rst:
https://review.coreboot.org/c/flashrom/+/82908/comment/27e5e9c5_15c8bfda?usp... : PS1, Line 120: This
Done […]
Yes, .rst to .html converting ignores new lines. Empty line will create a new paragraph.
File doc/contrib_howtos/how_to_add_new_chip.rst:
https://review.coreboot.org/c/flashrom/+/82908/comment/1900b6a3_dbc11a2f?usp... : PS2, Line 108: Some of the feature bits have more detailed docs, see below. Add new line (empty line) before #108