Change in flashrom[master]: ft2232_spi.c: Implement spi_send_multicommand()
Attention is currently required from: Nico Huber, Edward O'Callaghan, Samir Ibradžić. Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 ) Change subject: ft2232_spi.c: Implement spi_send_multicommand() ...................................................................... Patch Set 33: (1 comment) Patchset: PS32:
* I´m running flashrom on a virutal machine (don´t think this makes any difference) […] OK, I understand (I have/had got no idea of VM stuff).
So in case of not using VM, the speed we gain because of less USB communication is consumed by the increased processing time needed to pack the packages? Feel free to comment if you think this patch is worth to get merged. -- To view, visit https://review.coreboot.org/c/flashrom/+/40477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a Gerrit-Change-Number: 40477 Gerrit-PatchSet: 33 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Samir Ibradžić <sibradzic@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Samir Ibradžić <sibradzic@gmail.com> Gerrit-Comment-Date: Tue, 04 May 2021 08:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Buhrow Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment
participants (1)
-
Simon Buhrow (Code Review)