Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 )
Change subject: meson: relocate config_print_wiki & config_default_programmer_* ......................................................................
Patch Set 3:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64029/comment/9c543afb_4df28c9c PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
I think we cannot drop it for our chromium use cases... I can double-check though. […]
The C compiler doesn't know the value of default_programmer. For a human it's easy to spot that its NULL in the case CONFIG_DEFAULT_PROGRAMMER_NAME is NULL and the following code is not needed, but the compiler doesn't get it. So you get an `CONFIG_DEFAULT_PROGRAMMER_ARGS undeclared` error in any case if ifs not defined.