[S] Change in flashrom[master]: flashrom.c: Position heap alloc along side check in compare_range()

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Edward O'Callaghan.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69473 )

Change subject: flashrom.c: Position heap alloc along side check in compare_range()
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

Patchset:

PS1: 
+2 because it doesn't really matter from a functional point of view, c.f. the other comment. It's mostly a matter of style and/or personal preference.

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/69473/comment/1ac6d495_a5234214 
PS1, Line 451: 	uint8_t *cmpbuf = malloc(len);
Felix, from a functional standpoint, this change only swaps the order of two variable declarations (both of which were already initialised in-line). It shouldn't break anything w.r.t. declarations-before-code that wasn't already "broken".
> Why the ANSI C89 requirement, isn't C99 closer to 2023, nearly a 34yo requirement of the toolchain.

"The" toolchain? flashrom can be built with a variety of toolchains. Some of them, like https://en.wikipedia.org/wiki/DJGPP (to build flashrom for DOS), are quite unusual. It's a good idea to use util/manibuilder from time to time to do a more comprehensive build test. At the very least, we should use `util/manibuilder` to build test releases, but it'd be nice to build-test flashrom periodically (daily, or after a change is submitted).