Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/18207 )
Change subject: Free board_vendor and board_model vars before returning ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/18207/3/internal.c File internal.c:
https://review.coreboot.org/#/c/18207/3/internal.c@170 PS3, Line 170: #if IS_X86 || IS_ARM We should assume coreboot is available on all architectures
https://review.coreboot.org/#/c/18207/3/internal.c@222 PS3, Line 222: oard_parse_parameter(arg, &board_vendor, &board_model Would it make more sense to rewrite this function to avoid the layering issue that this patch is trying to fix?
Or maybe alloca() the space with a reasonable size and have board_parse_parameter copy the data instead of overwriting the pointer.
-
Stefan Reinauer (Code Review)