Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email )
Change subject: doc: Add build instructions for NI-845x on Windows
......................................................................
Patch Set 7:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/1cb48366_af287e71 :
PS5, Line 17: * linux-headers†
: * libpci†
: * libusb1†
: * libftdi1†
: * libjaylink†
: * NI-845x driver & library package‡
:
: | * optional, for building unit testing
: | † optional, depending on the selected programmer
: | ‡ optional, proprietary and Windows only. (See Windows build instructions)
I thought it made more sense to keep these near the list, since it seems unnecessarily difficult to […]
This is exactly what Sphinx gives us - `footnote-but-place-it-after-this-paragraph`! I've uploaded the new patchset, please check it out.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 05 Jun 2023 07:57:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment