Change in flashrom[staging]: fixup! Convert flashrom to git - flashrom-gerrit

4 Oct 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/21829 )
Change subject: fixup! Convert flashrom to git
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/21829/3/util/getrevision.sh
File util/getrevision.sh:
https://review.coreboot.org/#/c/21829/3/util/getrevision.sh@161
PS3, Line 161:         return unique revision information including an indicator for uncommitted changes
This line is too long. I said something about terminals,
didn't I? :-P
Please don't tell me that the 112 char rule also applies
to terminal output...
-- 
To view, visit https://review.coreboot.org/21829
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I6689ac24077b3981b471ed69de7cc3ef79d435b1
Gerrit-Change-Number: 21829
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Oct 2017 17:02:09 +0000
Gerrit-HasComments: Yes