[S] Change in flashrom[master]: tests: Add workaround to allow tests mock fileno on FreeBSD
Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Peter Marheine.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67312 )
Change subject: tests: Add workaround to allow tests mock fileno on FreeBSD ......................................................................
Patch Set 2:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/67312/comment/dde80f4a_f27cadab PS2, Line 161: __isthreaded = 0;
I don't think we should do this, since it's possible at this point that another thread has been crea […]
+1 also perhaps it maybe a good idea to set it right at the very beginning of the whole test suite not 'half way' in when the control flow arrives at setup_chip()
-
Edward O'Callaghan (Code Review)