[XL] Change in flashrom[master]: tree/: Convert flashchip read func ptr to enumerate
Attention is currently required from: Anastasia Klimchuk. Hello Felix Singer, build bot (Jenkins), Angel Pons, Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66788 to look at the new patch set (#17). Change subject: tree/: Convert flashchip read func ptr to enumerate ...................................................................... tree/: Convert flashchip read func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. TEST='R|W|E && --flash-name' on ARM, AMD & Intel DUT's. Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Signed-off-by: Edward O'Callaghan <quasisec@google.com> --- M flashchips.c M flashrom.c M fmap.c M include/flash.h M libflashrom.c M tests/chip.c M tests/chip_wp.c 7 files changed, 671 insertions(+), 607 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/66788/17 -- To view, visit https://review.coreboot.org/c/flashrom/+/66788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Gerrit-Change-Number: 66788 Gerrit-PatchSet: 17 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: newpatchset
participants (1)
-
Edward O'Callaghan (Code Review)