Change in flashrom[master]: ft2232_spi.c - Pack WREN and op in one ftdi_write_data() call to save... - flashrom-gerrit

27 Apr 2020


      Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c - Pack WREN and op in one ftdi_write_data() call to save programming time
......................................................................
Patch Set 6:
(1 comment)
...
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c 
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c@549 
PS2, Line 549: 		return 0;
...
Well, in the usual use case with maximum buf size equal to normal page program operations, I agree. […]
Done in patchset 6: Set buf to fix size to fix realloc issue.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 08:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Buhrow
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment