Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 )
Change subject: cli_classic: Make -r/-w/-v argument optional
......................................................................
Patch Set 6:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/52362/comment/95a4d087_6ab7830f
PS1, Line 1351: if ((image = fopen(filename, "rb")) == NULL) {
Ack
https://review.coreboot.org/c/flashrom/+/52362/comment/433606d3_b3cb5b0f
PS1, Line 1361:
: if (image_stat.st_size != (intmax_t)size) {
Ack
https://review.coreboot.org/c/flashrom/+/52362/comment/db03c03c_0f5f423d
PS1, Line 1439: if ((image = fopen(filename, "wb")) == NULL) {
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41
Gerrit-Change-Number: 52362
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 16 Apr 2021 16:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment