Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23005 )
Change subject: Add Manibuilder
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Looks good to my unknowing eyes.
Just noticed there is a readme.md file. If I find free time, I'll give it a good read and try to run Manibuilder.
For the record, so that I don't forget, anita is: http://www.gson.org/netbsd/anita/
[Off-topic] I thought the "Mani" in "Manibuilder" meant "many", but looks like I was wrong.
https://review.coreboot.org/c/flashrom/+/23005/3/util/manibuilder/README.md
File util/manibuilder/README.md:
https://review.coreboot.org/c/flashrom/+/23005/3/util/manibuilder/README.md@...
PS3, Line 4: hold
held
--
To view, visit
https://review.coreboot.org/c/flashrom/+/23005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982
Gerrit-Change-Number: 23005
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Jul 2019 19:41:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment