Change in flashrom[master]: ENE EDI - add dummy read to ensure proper detection of ENE chips
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23260 )
Change subject: ENE EDI - add dummy read to ensure proper detection of ENE chips ......................................................................
Patch Set 3: -Code-Review
(2 comments)
https://review.coreboot.org/#/c/23260/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23260/3//COMMIT_MSG@7 PS3, Line 7: ENE EDI - add dummy read to ensure proper detection of ENE chips
Is that the regular way to prefix commits in flashrom? […]
Yep, "edi: " as the file is named and then start in upper-case. It would also help with the line length (usual limit in git is 50 or 55 chars, iirc).
https://review.coreboot.org/#/c/23260/3/edi.c File edi.c:
https://review.coreboot.org/#/c/23260/3/edi.c@166 PS3, Line 166: static void edi_wakeup(struct flashctx *flash)
Nico, I don't really agree here (sorry for the delay in replying): this is really not about waking u […]
No, worries. I also thought about inlining it into edi_probe_kb9012(). That's probably the best. Otherwise, we'd have to keep making names up, edi_draw_attention()?
-
Nico Huber (Code Review)