Attention is currently required from: Nico Huber, Angel Pons.
Neill Corlett has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS1:
Thank you very much! it helps a lot to know what we are dealing with here. […]
Will address in a follow-up change as needed
File mediatek_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/61288/comment/337dcca9_c0fcce64
PS1, Line 242: GPIO line
At the very least, I'd add an option to enable WP# control.
Will address in a follow-up change as needed
https://review.coreboot.org/c/flashrom/+/61288/comment/ae9bb281_f759f7a9
PS1, Line 249: 0x426, 7
Having seen these kinds of datasheets before I know what you mean Neill lol. […]
Ack
https://review.coreboot.org/c/flashrom/+/61288/comment/2896e5f3_ea71de24
PS1, Line 255: 0x428, 7
What are these magic numbers?
See line #249
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I24adb14e7b4f7160e1c3ff941774064d5a81e820
Gerrit-Change-Number: 61288
Gerrit-PatchSet: 3
Gerrit-Owner: Neill Corlett
corlett@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Neill Corlett
corlett@google.com
Gerrit-MessageType: comment