Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67073 )
Change subject: usb_device.c: detach/attach usb kernel driver explicitly
......................................................................
Patch Set 3:
(1 comment)
File usb_device.c:
https://review.coreboot.org/c/flashrom/+/67073/comment/619bcf43_14668ba7
PS2, Line 349: libusb_error_name(ret));
Is the behavioral change intended?
The important step is the claiming of the interface. The detaching of a possible kernel driver is only a step to make it more likely to succeed. Now it should be more precise. If the detachment is successful or there was no kernel driver attached or the detachment is not supported it will continue. *The last past is true on FreeBSD for example.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1363fea13368b7ac1e9a3829864d06d123c4e157
Gerrit-Change-Number: 67073
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 01 Sep 2022 20:32:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment