Attention is currently required from: Anastasia Klimchuk, David Wu, Hsuan-ting Chen, Kapil Porwal, Maximilian Brune, Nikolai Artemiev, Subrata Banik.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79088?usp=email )
Change subject: flashchips: Add GD25LQ255E
......................................................................
Patch Set 11:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/79088/comment/e62528b7_d3be183a :
PS9, Line 6559: FEATURE_WRSR_EXT2
I tried to learn from the current code and Nikolai's first commit: https://review.coreboot. […]
Hi Hsuan-ting, thank you for helping collect and share these information!
Hi Anastasia and Nikolai, Would you mind help to take a look at previous comment?
IMO, it make sense. But I'm not an expert in flashrom.
Please help to review. And if it's look good to you, please help to mark it as `Resolved`. Thank you!
https://review.coreboot.org/c/flashrom/+/79088/comment/c79a297b_0b62ecf3 :
PS9, Line 6595: 1695, 1950
Okay I see that the other chip has the same range too. […]
Dear reviewers,
Please help to take a look on previous comment.
If you think modify the voltage is needed, please comment on the CL, thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d780255ed6772f4aa406584acf071a7ddd6da47
Gerrit-Change-Number: 79088
Gerrit-PatchSet: 11
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 02 Jan 2024 08:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment