Change in flashrom[master]: board_enable.c: Fix dead assignment - flashrom-gerrit

14 Mar 2022


      Attention is currently required from: Keith Hui, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 )
Change subject: board_enable.c: Fix dead assignment
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
...
I don't this change should affect the logic in any way but still wondering why were there 2 assignme […]
Maybe INB has some side-effects, for example doing something and then the assignment happens.
Keith, Idwer, maybe you know about it? Thank you!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 3
Gerrit-Owner: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Light aarya.chaumal@gmail.com
Gerrit-Comment-Date: Mon, 14 Mar 2022 08:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Light aarya.chaumal@gmail.com
Gerrit-MessageType: comment