Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58478 )
Change subject: flash: add structure to represent chip wp configuration ......................................................................
Patch Set 9:
(2 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58478/comment/c56968e4_a9ca7d59 PS9, Line 203: flashrom_ I am thinking... do we really need "flashrom" prefix in this struct type name? If "flash" is an important piece of info (I don't think so, but what if) maybe we can have `wp_flashchip_config` as a name?
https://review.coreboot.org/c/flashrom/+/58478/comment/6668f3cd_59cae7e8 PS9, Line 219: /* Used for intrepreting configuration bits above */ : const struct flashchip *chip; A question: is interpreting config bits implemented in CB:58479 or there are other patches? In CB:58479 all the places where chip config is used also have flash context available, and flashcontext has chip already. So just for CB:58479 this pointer is not needed?
-
Anastasia Klimchuk (Code Review)