Attention is currently required from: Hsuan-ting Chen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79229?usp=email )
Change subject: erase_func_algo: Avoid putting 0xff into buffers ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi Anastasia: […]
In theory, there could be more than one way to erase. In practice, the test is relying on the current implementation of erase/write which does it in one exact way.
If you are trying to adapt the test to chromium flashrom: last time I looked it had a different algorithm for erase/write. So don't be surprised if you see different erasers invocations for some of test cases. There was a plan for this year to merge two algos and get the best of both worlds. I measured the performance a year ago, and depending on the test case, one or other performed better. The plans did not happen, and now I guess it's up to you if you want to do that.