Attention is currently required from: Miklós Márton, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56636 )
Change subject: ni845x_spi: handle PROGRAMFILES(X86) env var properly
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Patchset:
PS1:
My build VM used during the review was a Windows 7 based one, and now I built a new VM with Windows […]
Ack
File Makefile:
https://review.coreboot.org/c/flashrom/+/56636/comment/cf981d4a_599b2807
PS1, Line 750: X
Yes env lists with upper case X.
Ack
https://review.coreboot.org/c/flashrom/+/56636/comment/5f135ec5_0369563b
PS1, Line 753: {PROGRAMFILES}
No need to use curly braces here. Also doesn't hurt, though.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56636
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I397619a5038567d649a417ce6b9d8ac9e1c8c67b
Gerrit-Change-Number: 56636
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 25 Aug 2021 21:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment