Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63488 )
Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings ......................................................................
ich_descriptors_tool: Fix -Wsign-compare warnings
This patch is needed to sync compiler warning options between meson and makefile.
TEST=running the following gives no warnings: meson setup --wipe (to clean build directory) ninja test
Change-Id: I1f9325e9cf89f57f18d63cc3906a0958b47286d7 Signed-off-by: Anastasia Klimchuk aklm@chromium.org --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/63488/1
diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index 13a1897..1979095 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -46,7 +46,6 @@ static void dump_file(const char *prefix, const uint32_t *dump, unsigned int len, const struct ich_desc_region *const reg, unsigned int i) { - int ret; char *fn; const char *reg_name; uint32_t file_len; @@ -85,7 +84,7 @@ } free(fn);
- ret = write(fh, &dump[base >> 2], file_len); + uint32_t ret = write(fh, &dump[base >> 2], file_len); if (ret != file_len) { fprintf(stderr, "FAILED.\n"); exit(1); @@ -267,7 +266,8 @@ prettyprint_ich_descriptors(cs, &desc);
pMAC = (uint8_t *) &buf[ICH_FREG_BASE(desc.region.FLREGs[3]) >> 2]; - if (len >= ICH_FREG_BASE(desc.region.FLREGs[3]) + 6 && pMAC[0] != 0xff) + /* The case len < 0 is handled above as error. At this point len is non-negative. */ + if (((uint32_t) len) >= ICH_FREG_BASE(desc.region.FLREGs[3]) + 6 && pMAC[0] != 0xff) printf("The MAC address might be at offset 0x%x: " "%02x:%02x:%02x:%02x:%02x:%02x\n", ICH_FREG_BASE(desc.region.FLREGs[3]),