Attention is currently required from: Shiyu Sun, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/a1bd8518_3c50fa7b PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now : and we need that to happen at the initialization of programmer.
Happy to +2 this however I still would like to see a better explanation as to why.
Since Shiyu is unavailable and this seems to fix a bug where 'Block protection could not be disabled' I think we can accept this and press forwards.