Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58518 )
Change subject: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS ......................................................................
Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS
NEED_LIBUSB1 is not used outside of the Makefile. No need to pass it to the compiler.
Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/58518 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 0b60de2..be1d59c 100644 --- a/Makefile +++ b/Makefile @@ -801,7 +801,6 @@ NEED_LIBUSB1 := $(call filter_deps,$(DEPENDS_ON_LIBUSB1)) ifneq ($(NEED_LIBUSB1), ) CHECK_LIBUSB1 = yes -FEATURE_CFLAGS += -D'NEED_LIBUSB1=1' PROGRAMMER_OBJS += usbdev.o usb_device.o # FreeBSD and DragonflyBSD use a reimplementation of libusb-1.0 that is simply called libusb ifeq ($(TARGET_OS), $(filter $(TARGET_OS), FreeBSD DragonFlyBSD))
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.