Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops - flashrom-gerrit

12 Sep 2021


      Attention is currently required from:  Felix Singer, Michał Żygowski, Paul Menzel, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS7:
...
Some feedback about the current state of the code vs open discussions would be appreciated. […]
I'm still confused why this is done deep in flashrom on the programmer path
and not in a separate binary (which could share any code necessary ofc). If
you could provide some details on the overall workflow, that could get the
discussion started I guess.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC:  Felix Singer felixsinger@posteo.net
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 12 Sep 2021 11:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-MessageType: comment