[S] Change in flashrom[1.1.x]: pickit2_spi: Fix "dead" assignment

[Nico Huber (Code Review)]

Attention is currently required from: Nico Huber.

Hello Felix Singer, build bot (Jenkins), Elyes Haouas,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/67846

to look at the new patch set (#2).

Change subject: pickit2_spi: Fix "dead" assignment
......................................................................

pickit2_spi: Fix "dead" assignment

We never read the first 'ret'. Let's check the first 'ret'
and exit if it failed.

Also, print the version only when the command succeeded.

Backported to libusb-v0 version (checking for CMD_LENGTH
instead of 0 return value).

Found-by: scan-build 7.0.1-8
Change-Id: I4aac5e1f3bd0604b079e1fdd9b7f09f1f4fc2d7f
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34403
---
M pickit2_spi.c
1 file changed, 27 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/67846/2