Change in flashrom[master]: meson: link flashrom binary against static libflashrom - flashrom-gerrit

4 May 2022


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64030 )
Change subject: meson: link flashrom binary against static libflashrom
......................................................................
Patch Set 1:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64030/comment/2bcb7195_1c8e95bf 
PS1, Line 477: # we can't just link_with libflashrom as we require all the internal symbols...
Obsolete comment?
https://review.coreboot.org/c/flashrom/+/64030/comment/74c42057_fb668014 
PS1, Line 489:   link_with : libflashrom.get_static_lib(), # flashrom needs internal symbols of libflashrom
This will fail if default_library is set to anything but 'both'. I think we actually want to use both_libraries because the static library is always needed and the shared library may be needed.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic522610f59e00299ebfa1bd29482ff92120ec52b
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 04 May 2022 00:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment