Attention is currently required from: Robert Zieba, Paul Menzel, Jon Murphy, Edward O'Callaghan, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63422 )
Change subject: sb600spi.c: Use SPI100 bit mappings
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63422/comment/e4d45c64_43adf072
PS1, Line 11: Stop using the legacy
: spi100 registers and use the correct ones.
give me a few hours to check with the docs that this won't break things on older platforms before la […]
had a look at the docs and all FCHs that have the SPI100 controller also have the SPI registers 0x45 and 0x47. All FCHs with the older SPI controller don't have the SPI registers 0x45 and 0x47.
Most of the FCHs with SPI100 have both the old (first 32bit register of SPI MMIO) and the new (SPI MMIO 0x45 and 0x47) mapping, but the newest SoCs don't have the old mapping any more.
Also spi100_spi_send_command already accesses registers 0x48 and 0x4b which aren't available on the old spi controllers, but are available on the spi100 controllers. when 0x48 and 0x4b are available, 0x45 and 0x47 will also be available.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If42130757331f4294b5a42c848557d3287f24fc3
Gerrit-Change-Number: 63422
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 20:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment