Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk.
Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 11:
(3 comments)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/3e14d559_1aef23a7?usp... : PS8, Line 624: flashrom_progress_callback_v2 *progress_callback; : struct flashrom_progress progress_state; : struct stage_progress stage_progress[FLASHROM_PROGRESS_NR]; : /* deprecated, do not use */ : flashrom_progress_callback *deprecated_progress_callback; : struct flashrom_progress *deprecated_progress_state;
I rebased to fix merge conflict in devel.rst (my favourite type of merge conflict :D) […]
That seems nice and consistent now, yes. It does occur to me that the most general solution would be to allow callers to register an arbitrary number of callbacks of either version (maintain a list of callbacks internally), but that doesn't seem necessary and would be more complex for users.
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86031/comment/00dab8ec_06e63eff?usp... : PS11, Line 76: since %s is deprecated May want to modify this message to use the same language as the one below, since the reason for both is that only one callback can be registered.
https://review.coreboot.org/c/flashrom/+/86031/comment/d96249ae_6494c19b?usp... : PS11, Line 93: "We recommend using flashrom_set_progress_callback_v2 instead of deprecated API " : "because flashrom_set_progress_callback fn is deprecated and will be removed " : "in future versions.\n" I don't think these sentences are necessary, because when we hit this condition the user will have already called `flashrom_set_progress_callback` and gotten the deprecation warning from it.
-
Peter Marheine (Code Review)