Change in flashrom[master]: tests: Add tests for verify operation - flashrom-gerrit

10 Jan 2022


      Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59239 )
Change subject: tests: Add tests for verify operation
......................................................................
Patch Set 4:
(3 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/59239/comment/c6fe69ed_f0a4765c 
PS4, Line 377: do_verify
please target the libflashrom API not the CLI helpers.
https://review.coreboot.org/c/flashrom/+/59239/comment/56952eaf_026724b2 
PS4, Line 417: do_write
ditto
https://review.coreboot.org/c/flashrom/+/59239/comment/0a47511b_00d9f50f 
PS4, Line 421: do_verify
ditto
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59239
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1cc6f73f9b1e385eb963adccf20759c13a40ed3b
Gerrit-Change-Number: 59239
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 10 Jan 2022 02:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment