[S] Change in flashrom[master]: flashrom.c: Reduce the prog global state machine

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Thomas Heijligen.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70603 )

Change subject: flashrom.c: Reduce the prog global state machine
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> Why saving the result of `prog == &programmer_internal`? Can we put this just in `static bool is_int […]

Unfortunately not as the call sites do not have access to the prog but rather the inner flashctx. This patch is really just meant to plug the hole to prevent things getting worse - avoid dispatch getting reintroduced via the global handle and instead keeping globals as only read-only lookup which isn't the worst problem.

I know how to fix this but the change is extensive and fundamentally changes how drivers are registered. I wish to video chat about it with some drawing program as there is a lot to describe.