Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62726 )

Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments
......................................................................

serprog.c: Avoid calling memcpy with NULL pointer arguments

In function sp_stream_buffer_op, the variable parms might be NULL when
passed to memcpy. Although, since parmlen is also 0 at that time I
don't think it would make much difference. Still, add a NULL check
before calling memcpy to be safe.

Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b
Signed-off-by: Aarya Chaumal 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62726
Tested-by: build bot (Jenkins) 
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Anastasia Klimchuk 
Reviewed-by: Thomas Heijligen 
Reviewed-by: Nico Huber 
---
M serprog.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, but someone else must approve
  Thomas Heijligen: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, but someone else must approve
  Anastasia Klimchuk: Looks good to me, approved

diff --git a/serprog.c b/serprog.c
index 2bbf44b..ea2bbf0 100644
--- a/serprog.c
+++ b/serprog.c
@@ -291,7 +291,8 @@
    	return 1;
    }
    sp[0] = cmd;
-	memcpy(&(sp[1]), parms, parmlen);
+	if (parms)
+		memcpy(&(sp[1]), parms, parmlen);

if (sp_streamed_transmit_bytes >= (1 + parmlen + sp_device_serbuf_size)) {
    	if (sp_flush_stream() != 0) {