Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60110 )
Change subject: hwaccess: move x86 port I/O related code into own files ......................................................................
Patch Set 5:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60110/comment/6e467f4f_742e6516 PS4, Line 783: ifneq ($(NEED_RAW_ACCESS), ) : # Raw memory, MSR or PCI port I/O access. : FEATURE_CFLAGS += -D'NEED_RAW_ACCESS=1' -D'__FLASHROM_HAVE_OUTB__=1' : PROGRAMMER_OBJS += physmap.o hwaccess.o hwaccess_x86_io.o
Yes, currently it's disabling all libpci programmer and rayer_spi. […]
`make CONFIG_ENABLE_LIBPCI_PROGRAMMERS=no CONFIG_RAYER_SPI=no` build successful on x86_64 Linux and hwaccess* files are not build as expected.
NEED_RAW_ACCESS is an internal make variable. This should not be overwritten by the user. So `make NEED_RAW_ACCESS=` is not supported. The user should select the programmers to build and the Makefile selects all necessary features for them or disable the programmer when it's not supported on the platform.
-
Thomas Heijligen (Code Review)