Attention is currently required from: Nico Huber, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62282/comment/cc0a8317_3c9aec7b
PS4, Line 10: TEST=dedede with `flashrom -p internal --flash-size`.
Thanks Angel, a rw was tested to validate it doesn't regress the chromeos fw update mechanism. […]
Done
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/6fe33345_11e7adc9
PS4, Line 1064: case CHIPSET_JASPER_LAKE:
Just FYI Angel, I cannot control how public the data sheets are however I can have Intel collabora […]
😄 well the documentation pretty much wasn't great for this gen but I finally got some time to figure out the value of CSSO to branch off to get the detection logic working so guess would work.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d
Gerrit-Change-Number: 62282
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment