Attention is currently required from: Angel Pons, Nikolai Artemiev, Stefan Reinauer, mans0n+coreboot@gorani.run.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63516?usp=email )
Change subject: flashchips: Add support for XMC XM25QH80B ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS1:
Hi, […]
Sungbo, thank you so much for your contribution, sorry that your patch was lost and hanging for so long. We had some structural changes in flashchips.c file since the time you sent the patch. So I made the changes to your chip definition and rebased your patch on head.
You did it right with reusing model_id of ST_M45PE80 and adding a comment.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/63516/comment/f31cfea6_fd673f2e : PS3, Line 20776: SPI_PRETTYPRINT_STATUS_REGISTER_BP2_SRWD I am not entirely sure about this one, we have 4 different functions to prettyprint with BP2 and it would be ideal if another reviewer checks this is correct function. Thank you!
Initial patch had plain prettyprint, but I think we can use one of BP2 ones?
-
Anastasia Klimchuk (Code Review)