Change in flashrom[master]: pcidev.c: Move pci_card_find() from internal to canonical place - flashrom-gerrit

15 Dec 2021


      Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59279 )
Change subject: pcidev.c: Move pci_card_find() from internal to canonical place
......................................................................
Patch Set 1:
(2 comments)
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/59279/comment/b39d0a4c_1b37ac33 
PS1, Line 188: 			      uint16_t card_vendor, uint16_t card_device)
Please fix indentation.
File programmer.h:
https://review.coreboot.org/c/flashrom/+/59279/comment/a1eee550_feb4dfb7 
PS1, Line 131: 			      uint16_t card_vendor, uint16_t card_device);
IIRC, the rule was no line breaks in header files. To ease greppability.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I026bfbecba114411728d4ad1ed8969b469fa7d2d
Gerrit-Change-Number: 59279
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Wed, 15 Dec 2021 11:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment