Change in flashrom[master]: cli_classic.c: Convert do_erase() to libflashrom call

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60068 )

Change subject: cli_classic.c: Convert do_erase() to libflashrom call
......................................................................

Patch Set 2:

(1 comment)

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/60068/comment/38f758de_85d582c4 
PS2, Line 1936: /*
              : 	 * FIXME: Do we really want the scary warning if erase failed?
              : 	 * After all, after erase the chip is either blank or partially
              : 	 * blank or it has the old contents. A blank chip won't boot,
              : 	 * so if the user wanted erase and reboots afterwards, the user
              : 	 * knows very well that booting won't work.
              : 	 */
              : 	if (ret)
              : 		emergency_help_message();
> I am just a little bit confused. […]

If you recall, logging does occur however though the callback mechanism in the API.