[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW - flashrom-gerrit

6 Dec 2024


      Attention is currently required from: Hsuan Ting Chen, Kapil Porwal.
Anastasia Klimchuk has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email )
Change subject: flashchips.c: Add reg_bits for W25Q256JW
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
Thanks everyone, for contribution and reviews! […]
Kapil, the patch CB:83307 is submitted, so you can go ahead.
You need to move your code to `winbond.c`, upload new patchset (make sure it builds), and then resolve this comment. Thanks.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e
Gerrit-Change-Number: 85323
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Hsuan Ting Chen roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen roccochen@google.com
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen roccochen@chromium.org
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Comment-Date: Fri, 06 Dec 2024 06:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org