Attention is currently required from: Shiyu Sun, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49786 )
Change subject: realtek_mst_i2c_spi.c: Skip return value check for reset function
......................................................................
Patch Set 2:
(1 comment)
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/49786/comment/1627c45d_0f3bff4f
PS1, Line 431: /* Return value for reset mpu is not checked since
: * the return value is not guaranteed to be 0 on a
: * success reset. Currently there is no way to fix that.
: * For more details see b:147402710. */
Comment style should be: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06
Gerrit-Change-Number: 49786
Gerrit-PatchSet: 2
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shiyu Sun
sshiyu@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 12:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment