Attention is currently required from: Nico Huber, Edward O'Callaghan, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add functions for reading/writing WP configs
......................................................................
Patch Set 35:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58479/comment/128cadfd_8f2bbb15
PS34, Line 11: a
spurious `a`
Done
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/4c999f8c_68bc43ea
PS34, Line 151:
excessive empty line
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/667a7ccd_2980efbd
PS34, Line 717: * has its own WP operations we should use instead.
Shouldn't we check the type right away and return an error in case? […]
Done
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/7af6ac58_809c4b35
PS34, Line 51: = FLASHROM_WP_OK
This is overwritten on the very next line.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ad25708c3321b8fb0216c3eaf6ffc07616537ad
Gerrit-Change-Number: 58479
Gerrit-PatchSet: 35
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 18 Feb 2022 07:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment