Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55117 )
Change subject: programmer_table: replace PROGRAMMER_INVALID with programmer_table_size
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55117/comment/49baf3f0_0c3f5990
PS3, Line 7: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations
I want to introduce first all necessary items before using them
Ack from my side.
The commit-split felt quite digestible. Smaller commits keep me focused.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84
Gerrit-Change-Number: 55117
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment